lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Nov 2015 18:42:38 -0700 From: Jerry Hoemann <jerry.hoemann@....com> To: Jeff Moyer <jmoyer@...hat.com> Cc: ross.zwisler@...ux.intel.com, rjw@...ysocki.net, lenb@...nel.org, dan.j.williams@...el.com, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, linux-nvdimm@...1.01.org Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoemann@....com> writes: > > > + uuid = pkg->h.dsm_uuid; > > + rev = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1; > > Shouldn't revision id be required? > Yes it should be. Good catch. I was testing use of reclaiming previously unused members of the structure. I should have removed this line. And this reminds me that I should also add a test that the reserved fields of ndn_pkg are actually zero. I'll address both in version 2. thanks -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett-Packard Enterprise ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists