lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2015 19:07:19 +0300 From: Vladimir Davydov <vdavydov@...tuozzo.com> To: Tejun Heo <tj@...nel.org> CC: Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, Greg Thelen <gthelen@...gle.com>, Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, <linux-mm@...ck.org>, <cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 4/6] slab: add SLAB_ACCOUNT flag On Wed, Nov 11, 2015 at 10:54:50AM -0500, Tejun Heo wrote: > Hello, > > On Tue, Nov 10, 2015 at 09:54:01PM +0300, Vladimir Davydov wrote: > > > Am I correct in thinking that we should eventually be able to removed > > > __GFP_ACCOUNT and that only caches explicitly marked with SLAB_ACCOUNT > > > would need to be handled by kmemcg? > > > > Don't think so, because sometimes we want to account kmalloc. > > I'm kinda skeptical about that because if those allocations are > occassional by nature, we don't care and if there can be a huge number > of them, splitting them into a separate cache makes sense. I think it > makes sense to pin down exactly which caches are memcg managed. That > has the potential to simplify the involved code path and shave off a > small bit of hot path overhead. What about external_name allocation in __d_alloc? Is it occasional? Depends on the workload I guess. Can we create a separate cache for it? No, because its size is variable. There are other things like that, e.g. pipe_buffer array. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists