lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2015 21:02:26 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Felipe Ferreri Tonello <eu@...ipetonello.com>, linux-usb@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Robert Baldyga <r.baldyga@...sung.com>, Clemens Ladisch <clemens@...isch.de> Subject: Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface Hello. On 11/11/2015 12:38 PM, Felipe Ferreri Tonello wrote: >>> This avoids duplication of USB requests for OUT endpoint and >>> re-enabling endpoints. >>> >>> Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com> >>> --- >>> drivers/usb/gadget/function/f_midi.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/gadget/function/f_midi.c >>> b/drivers/usb/gadget/function/f_midi.c >>> index 76ea53c..615d632 100644 >>> --- a/drivers/usb/gadget/function/f_midi.c >>> +++ b/drivers/usb/gadget/function/f_midi.c >>> @@ -75,6 +75,7 @@ struct f_midi { >>> struct usb_ep *in_ep, *out_ep; >>> struct snd_card *card; >>> struct snd_rawmidi *rmidi; >>> + u8 ms_id; >> >> Why 'ms_id' is not aligned with the above field names? > > It is actually aligned. Perhaps because of the +? No, + should not affect this, it only affects things when a line doesn't start with a tab. > Here is from my local git diff: > > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -75,6 +75,7 @@ struct f_midi { > struct usb_ep *in_ep, *out_ep; > struct snd_card *card; > struct snd_rawmidi *rmidi; > + u8 ms_id; Unfortunately, tabs got replaces with spaces in this fragment. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists