linux-kernel - Re: [PATCH 1/1] usblp: do not set TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 16:28:16 -0700
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	zaitcev@...hat.com
Subject: Re: [PATCH 1/1] usblp: do not set TASK_INTERRUPTIBLE before lock

On Mon,  2 Nov 2015 10:27:00 +0100
Jiri Slaby <jslaby@...e.cz> wrote:

> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> --- a/drivers/usb/class/usblp.c
> +++ b/drivers/usb/class/usblp.c
> @@ -884,11 +884,11 @@ static int usblp_wwait(struct usblp *usblp, int nonblock)
>  
>  	add_wait_queue(&usblp->wwait, &waita);
>  	for (;;) {
> -		set_current_state(TASK_INTERRUPTIBLE);
>  		if (mutex_lock_interruptible(&usblp->mut)) {
>  			rc = -EINTR;
>  			break;
>  		}
> +		set_current_state(TASK_INTERRUPTIBLE);
>  		rc = usblp_wtest(usblp, nonblock);
>  		mutex_unlock(&usblp->mut);
>  		if (rc <= 0)

I'm fully onboard with this. In the original "big cleanup" 317c67b8f,
I got this right. But then I either missed that mutex_lock_interruptible()
can set the state, or it didn't do it back then (it was in 2007), and
the 7f477358e introduced the existing code.

Acked-By: Pete Zaitcev <zaitcev@...oo.com>

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/