linux-kernel - Re: [PATCH] mtd: nand: atmel_nand: fix a possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201511121748.2SYvLaTJ%fengguang.wu@intel.com>
Date:	Thu, 12 Nov 2015 17:06:35 +0800
From:	kbuild test robot <lkp@...el.com>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	kbuild-all@...org, computersforpeace@...il.com,
	dwmw2@...radead.org, josh.wu@...el.com,
	LABBE Corentin <clabbe.montjoie@...il.com>,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] mtd: nand: atmel_nand: fix a possible NULL dereference

Hi LABBE,

[auto build test WARNING on mtd/master]
[also build test WARNING on v4.3 next-20151112]

url:    https://github.com/0day-ci/linux/commits/LABBE-Corentin/mtd-nand-atmel_nand-fix-a-possible-NULL-dereference/20151112-155258
base:   git://git.infradead.org/linux-mtd.git master
config: arm-at91_dt_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/mtd/nand/atmel_nand.c: In function 'atmel_of_init_port':
>> drivers/mtd/nand/atmel_nand.c:1503:13: warning: assignment discards 'const' qualifier from pointer target type
     host->caps = of_id->data;
                ^

vim +/const +1503 drivers/mtd/nand/atmel_nand.c

  1487	
  1488	static const struct of_device_id atmel_nand_dt_ids[];
  1489	
  1490	static int atmel_of_init_port(struct atmel_nand_host *host,
  1491				      struct device_node *np)
  1492	{
  1493		u32 val;
  1494		u32 offset[2];
  1495		int ecc_mode;
  1496		struct atmel_nand_data *board = &host->board;
  1497		enum of_gpio_flags flags = 0;
  1498		const struct of_device_id *of_id;
  1499	
  1500		of_id = of_match_device(atmel_nand_dt_ids, host->dev);
  1501		if (!of_id)
  1502			return -ENODEV;
> 1503		host->caps = of_id->data;
  1504	
  1505		if (of_property_read_u32(np, "atmel,nand-addr-offset", &val) == 0) {
  1506			if (val >= 32) {
  1507				dev_err(host->dev, "invalid addr-offset %u\n", val);
  1508				return -EINVAL;
  1509			}
  1510			board->ale = val;
  1511		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (20006 bytes)