linux-kernel - Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151112091349.GA3402@shlinux2>
Date:	Thu, 12 Nov 2015 17:13:50 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	Tim Bird <tim.bird@...ymobile.com>
CC:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"balbi@...com" <balbi@...com>,
	Andersson, Björn 
	<Bjorn.Andersson@...ymobile.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tbird20d@...il.com" <tbird20d@...il.com>
Subject: Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for
 dragonboard OTG port

On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote:
> 
> 
> On 11/10/2015 07:14 PM, Peter Chen wrote:
> > On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote:
> >> This fixes a bug where if you disconnect and re-connect the USB cable,
> >> the gadget driver stops working.
> >>
> >> Add support for async_irq to wake up driver from low power mode.
> >> Without this, the power management code never calls resume.
> >> Also, have the phy driver kick the gadget driver (chipidea otg)
> >> by having the chipidea driver register with it, for vbus connect
> >> notifications.
> >>
> >> Signed-off-by: Tim Bird <tim.bird@...ymobile.com>
> >> ---
> >>  drivers/usb/chipidea/udc.c    |  6 ++++++
> >>  drivers/usb/phy/phy-msm-usb.c | 16 ++++++++++++++++
> >>  include/linux/usb/msm_hsusb.h |  1 +
> >>  3 files changed, 23 insertions(+)
> >>
> >> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> >> index 8223fe7..06234cd 100644
> >> --- a/drivers/usb/chipidea/udc.c
> >> +++ b/drivers/usb/chipidea/udc.c
> >> @@ -1890,6 +1890,12 @@ static int udc_start(struct ci_hdrc *ci)
> >>  
> >>  	ci->gadget.ep0 = &ci->ep0in->ep;
> >>  
> >> +	if (ci->usb_phy) {
> >> +		retval = otg_set_peripheral(ci->usb_phy->otg, &ci->gadget);
> >> +		if (retval)
> >> +			goto destroy_eps;
> >> +	}
> >> +
> >>  	retval = usb_add_gadget_udc(dev, &ci->gadget);
> >>  	if (retval)
> >>  		goto destroy_eps;
> > 
> > Although it looks no affect for other drivers, it is better you
> > can split patches between controller and phy, then I can have a test.
> 
> OK.
> 
> > In fact, most of phy-msm-usb.c's implementations (except USB PHY related)
> > are included in chipidea drivers, hope you can try it in future.
> 
> I would like to do this.  I'm pretty confused about the relationship between
> ehci, chipidea and the phy code, with regard to managing the controller
> hardware.

Chipidea is controller driver, it manages ehci (host.c) , udc (udc.c),
and otg (otg.c and otg-fsm.c), all controller related resources are
managed by chipidea driver, and it calls usb_phy (or phy)'s API when
it needs to access PHY.

The PHY code is another driver, and chipidea can get PHY through the
dts, the PHY reference can be phandle in controler's node.
(see arch/arm/boot/dts/imx6qdl.dts for reference).

> Is there a phy in mainline that is a good example of having most
> of the controller support in the chipidea driver rather than in the phy?
> 

Many of them, in fact, the PHY driver should not include controller
access, otherwise, there are two drivers access the same register
region.

drivers/usb/phy/phy-mxs-usb.c
drivers/phy/phy-berlin-usb.c
drivers/usb/phy/phy-generic.c

Just grep compatible string described at
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
at ARM dts folder, and find the PHY node at related
dts, then you will know their PHY driver.

Peter

> Thanks!
>  
> >> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> >> index 80eb991..eb80f92 100644
> >> --- a/drivers/usb/phy/phy-msm-usb.c
> >> +++ b/drivers/usb/phy/phy-msm-usb.c
> >> @@ -1731,6 +1731,12 @@ static int msm_otg_probe(struct platform_device *pdev)
> >>  		return motg->irq;
> >>  	}
> >>  
> >> +	motg->async_irq = platform_get_irq_byname(pdev, "async_irq");
> >> +	if (motg->async_irq < 0) {
> >> +		dev_info(&pdev->dev, "platform_get_irq for async_irq failed\n");
> >> +		motg->async_irq = 0;
> >> +	}
> >> +
> > 
> > dev_err
> 
> OK - I'll change this.  I've listed the async_irq as optional in the binding doc,
> so I don't actually error out, but I was unsure the appropriate error level for
> this message.
> 
> Thanks for the feedback!
>  -- Tim

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/