linux-kernel - Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vce=uy7z-ug7Q1crvnv34zteyMn61QJ3y_Qkts0f03TMQ@mail.gmail.com>
Date:	Thu, 12 Nov 2015 11:41:37 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	dave penkler <dpenkler@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	peter.chen@...escale.com, teuniz@...il.com,
	USB <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dpenkler@...il.org
Subject: Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488
 READ_STATUS_BYTE operation.

On Thu, Nov 12, 2015 at 11:07 AM, dave penkler <dpenkler@...il.com> wrote:
> Thanks for your comments, I will resubmit taking into account all
> suggestions.
>
>> >  - redundant parens

Example 1.
+                       (atomic_read(&data->iin_data_valid) != 0),

>> >  - pieces of code takes whole line when they are quite fit tail of
>> > previous one.
>> >
>
>
> I have endeavoured to follow the coding style of the original driver and
> stick to the kernel coding-style guidelines.
> Please point to the specific locations where I have failed to do so.

Example 1.
+               dev_err(dev, "control status returned %x\n",
+                       buffer[0]);

example 2.
+                       USBTMC_TIMEOUT
+                       );


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/