linux-kernel - Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Nov 2015 11:01:10 +0100
From:	Matias Bjørling <m@...rling.me>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Jens Axboe <axboe@...com>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-nvme@...ts.infradead.org,
	Christoph Hellwig <hch@...radead.org>, jg@...htnvm.io,
	Stephen.Bates@...s.com, Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs

On 11/11/2015 11:46 PM, Geert Uytterhoeven wrote:
> On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@...rling.me> wrote:
>> +struct nvm_dev_ops {
>
> [...]
>
>> +       uint8_t                 max_phys_sect;
>> +};
>
>> --- /dev/null
>> +++ b/drivers/lightnvm/core.c
>
>> +int nvm_register(struct request_queue *q, char *disk_name,
>> +                                                       struct nvm_dev_ops *ops)
>> +{
>
> [...]
>
>> +       } else if (dev->ops->max_phys_sect > 256) {
>
> drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
> to limited range of data type
>
> Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
>
>> +               pr_info("nvm: max sectors supported is 256.\n");
>
> Hence this message is not correct. What's the intended maximum value?
> 255 or 256?

Good catch. It'll be 256, the typically device driver supports 64. The 
256 is just an upper sensible bound. I'll create a patch to make it an 
unsigned short.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/