lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Nov 2015 10:17:40 +0800 From: "Lu, Baolu" <baolu.lu@...ux.intel.com> To: Alan Stern <stern@...land.harvard.edu> Cc: Mathias Nyman <mathias.nyman@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device On 11/11/2015 11:10 PM, Alan Stern wrote: > On Wed, 11 Nov 2015, Lu Baolu wrote: > >> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.") >> adds usb3_lpm_enabled member to struct usb_device. There is no reference >> to this member now. Hence, it could be removed. >> >> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com> >> --- >> include/linux/usb.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/usb.h b/include/linux/usb.h >> index 211664f..036e4a5 100644 >> --- a/include/linux/usb.h >> +++ b/include/linux/usb.h >> @@ -583,7 +583,6 @@ struct usb_device { >> unsigned usb2_hw_lpm_besl_capable:1; >> unsigned usb2_hw_lpm_enabled:1; >> unsigned usb2_hw_lpm_allowed:1; >> - unsigned usb3_lpm_enabled:1; >> unsigned usb3_lpm_u1_enabled:1; >> unsigned usb3_lpm_u2_enabled:1; >> int string_langid; > You forgot to remove the kerneldoc for this field. And you forgot to > add kerneldoc for usb3_lpm_u[12]_enabled. Yes. I will fix this in v2. > > Alan Stern Thanks, Baolu > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists