linux-kernel - Re: input: i8042: build failure on powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Nov 2015 07:41:17 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: input: i8042: build failure on powerpc

On Thu, Nov 12, 2015 at 04:01:45PM +0100, LABBE Corentin wrote:
> Hello
> 
> I have made a random .config for testing my powerpc cross-compiler and I got this fail:
> 

In general it helps to provide the broken configuration.

If you do some digging, you may notice that this has been broken
since commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
or in other words since 2008. CONFIG_INPUT is not set with walnut_defconfig,
which may explain why no one noticed.

I would suggest to just remove the offending code. Quite obviously it is dead.

Guenter

>   LD      init/built-in.o
> drivers/built-in.o: In function `i8042_wait_write':
> i8042.c:(.text+0x13d8be): undefined reference to `kb_cs'
> i8042.c:(.text+0x13d8c6): undefined reference to `kb_cs'
> i8042.c:(.text+0x13d8e6): undefined reference to `kb_cs'
> drivers/built-in.o: In function `i8042_kbd_write':
> i8042.c:(.text+0x13d9aa): undefined reference to `kb_data'
> i8042.c:(.text+0x13d9ae): undefined reference to `kb_data'
> drivers/built-in.o: In function `i8042_flush':
> i8042.c:(.text+0x13da56): undefined reference to `kb_cs'
> i8042.c:(.text+0x13da62): undefined reference to `kb_cs'
> i8042.c:(.text+0x13da66): undefined reference to `kb_data'
> i8042.c:(.text+0x13da86): undefined reference to `kb_data'
> drivers/built-in.o: In function `i8042_panic_blink':
> i8042.c:(.text+0x13db92): undefined reference to `kb_cs'
> i8042.c:(.text+0x13db9a): undefined reference to `kb_cs'
> i8042.c:(.text+0x13dc06): undefined reference to `kb_data'
> i8042.c:(.text+0x13dc16): undefined reference to `kb_data'
> i8042.c:(.text+0x13dc8a): undefined reference to `kb_data'
> drivers/built-in.o: In function `i8042_interrupt':
> i8042.c:(.text+0x13dd1a): undefined reference to `kb_cs'
> i8042.c:(.text+0x13dd1e): undefined reference to `kb_cs'
> i8042.c:(.text+0x13dd3e): undefined reference to `kb_data'
> i8042.c:(.text+0x13dd42): undefined reference to `kb_data'
> drivers/built-in.o: In function `__i8042_command':
> i8042.c:(.text+0x13e2b6): undefined reference to `kb_cs'
> i8042.c:(.text+0x13e2be): undefined reference to `kb_cs'
> i8042.c:(.text+0x13e2ea): undefined reference to `kb_data'
> i8042.c:(.text+0x13e302): undefined reference to `kb_data'
> i8042.c:(.text+0x13e34e): undefined reference to `kb_cs'
> i8042.c:(.text+0x13e362): undefined reference to `kb_cs'
> i8042.c:(.text+0x13e366): undefined reference to `kb_data'
> i8042.c:(.text+0x13e3de): undefined reference to `kb_data'
> drivers/built-in.o: In function `i8042_aux_test_irq':
> i8042.c:(.init.text+0x59a2): undefined reference to `kb_cs'
> i8042.c:(.init.text+0x59a6): undefined reference to `kb_cs'
> i8042.c:(.init.text+0x59ca): undefined reference to `kb_data'
> i8042.c:(.init.text+0x59ce): undefined reference to `kb_data'
> drivers/built-in.o: In function `i8042_probe':
> i8042.c:(.init.text+0x5dda): undefined reference to `kb_cs'
> i8042.c:(.init.text+0x5dde): undefined reference to `kb_cs'
> i8042.c:(.init.text+0x6366): undefined reference to `kb_data'
> i8042.c:(.init.text+0x6376): undefined reference to `kb_cs'
> i8042.c:(.init.text+0x637a): undefined reference to `kb_data'
> Makefile:929: recipe for target 'vmlinux' failed
> 
> it seems that kb_data and kb_cs (declared as extern in drivers/input/serio/i8042-ppcio.h) are defined anywhere.
> 
> Regards
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/