lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5644B4F4.5090805@kernel.dk>
Date:	Thu, 12 Nov 2015 08:49:08 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@...radead.org>,
	Matias Bj??rling <m@...rling.me>
Cc:	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	axboe@...com
Subject: Re: [PATCH] null_blk: Register as a LightNVM device

On 11/12/2015 01:53 AM, Christoph Hellwig wrote:
> On Wed, Nov 11, 2015 at 11:06:38AM +0100, Matias Bj??rling wrote:
>> Add support for registering as a LightNVM device. This allows us to
>> evaluate the performance of the LightNVM library.
>>
>> In /drivers/Makefile, LightNVM is moved above block device drivers
>> to make sure that the LightNVM media managers have been initialized
>> before drivers under /drivers/block are initialized.
>
> I don't think mixing the lighnvm code into null_blk is a good idea.
> Please just create a separate null_nvm device for lighnvm. It already
> has a completely separate I/O path.

But it still avoids duplicating the generics of it. Patch for null_blk:

3 files changed, 168 insertions(+), 7 deletions (-)

vs a standalone of:

3 files changed, 459 insertions(+)

It doesn't screw up null_blk, so I'd prefer just adding it as an 
on-the-side mode for that.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ