linux-kernel - Re: [PATCH] null_blk: Register as a LightNVM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5644B648.6060500@fb.com>
Date:	Thu, 12 Nov 2015 08:54:48 -0700
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@...radead.org>, Jens Axboe <axboe@...nel.dk>
CC:	Matias Bj??rling <m@...rling.me>, <linux-block@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] null_blk: Register as a LightNVM device

On 11/12/2015 08:52 AM, Christoph Hellwig wrote:
> On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote:
>> But it still avoids duplicating the generics of it. Patch for null_blk:
>>
>> 3 files changed, 168 insertions(+), 7 deletions (-)
>>
>> vs a standalone of:
>>
>> 3 files changed, 459 insertions(+)
>>
>> It doesn't screw up null_blk, so I'd prefer just adding it as an on-the-side
>> mode for that.
>
> 300 lines of boilerplate for just setting up a few request_queues seem
> wrong, can you show the actual patch you measured?

I just took it from Matias' last posting:

http://marc.info/?l=linux-kernel&m=144605858228534&w=2

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/