lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Nov 2015 13:39:02 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Pankaj Dubey <pankaj.dubey@...sung.com>, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Cc: kgene.kim@...sung.com, thomas.ab@...sung.com, amitdanielk@...il.com, olof@...om.net, khilman@...aro.org, arnd@...db.de Subject: Re: [PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver On 10.11.2015 20:43, Pankaj Dubey wrote: > This patch moves exynos_sys_powerdown_conf function above all > static functions. Please (always) describe the reason, the answer to "why?". In this case I know why, but other reviewers may not and other people grepping through history definitely won't know. Best regards, Krzysztof > > Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com> > --- > arch/arm/mach-exynos/pmu.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c > index e01bdf1..f300ac9 100644 > --- a/arch/arm/mach-exynos/pmu.c > +++ b/arch/arm/mach-exynos/pmu.c > @@ -39,23 +39,6 @@ u32 pmu_raw_readl(u32 offset) > return readl_relaxed(pmu_base_addr + offset); > } > > -static void exynos_power_off(void) > -{ > - unsigned int tmp; > - > - pr_info("Power down.\n"); > - tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL); > - tmp ^= (1 << 8); > - pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL); > - > - /* Wait a little so we don't give a false warning below */ > - mdelay(100); > - > - pr_err("Power down failed, please power off system manually.\n"); > - while (1) > - ; > -} > - > void exynos_sys_powerdown_conf(enum sys_powerdown mode) > { > unsigned int i; > @@ -85,6 +68,23 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode) > } > } > > +static void exynos_power_off(void) > +{ > + unsigned int tmp; > + > + pr_info("Power down.\n"); > + tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL); > + tmp ^= (1 << 8); > + pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL); > + > + /* Wait a little so we don't give a false warning below */ > + mdelay(100); > + > + pr_err("Power down failed, please power off system manually.\n"); > + while (1) > + ; > +} > + > static int pmu_restart_notify(struct notifier_block *this, > unsigned long code, void *unused) > { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists