lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Nov 2015 09:11:38 +0100 From: Clemens Ladisch <clemens@...isch.de> To: Felipe Ferreri Tonello <eu@...ipetonello.com>, Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, linux-usb@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Robert Baldyga <r.baldyga@...sung.com> Subject: Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface Felipe Ferreri Tonello wrote: > On 10/11/15 18:43, Sergei Shtylyov wrote: >> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote: >>> @@ -75,6 +75,7 @@ struct f_midi { >>> struct usb_ep *in_ep, *out_ep; >>> struct snd_card *card; >>> struct snd_rawmidi *rmidi; >>> + u8 ms_id; >> >> Why 'ms_id' is not aligned with the above field names? > > It is actually aligned. It's not in the original mail, which contains tab characters. > Here is from my local git diff: > > @@ -75,6 +75,7 @@ struct f_midi { > struct usb_ep *in_ep, *out_ep; > struct snd_card *card; > struct snd_rawmidi *rmidi; > + u8 ms_id; Apparently, you're using four spaces per tab. Linux uses eight. Regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists