lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <5645A079.2070904@samsung.com>
Date:	Fri, 13 Nov 2015 09:34:01 +0100
From:	Robert Baldyga <r.baldyga@...sung.com>
To:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	linux-usb@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH v5 5/7] usb: gadget: gmidi: Cleanup legacy code

On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
> Remove unnecessary headers and variables.
> 
> Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com>

Reviewed-by: Robert Baldyga <r.baldyga@...sung.com>

> ---
>  drivers/usb/gadget/legacy/gmidi.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/usb/gadget/legacy/gmidi.c b/drivers/usb/gadget/legacy/gmidi.c
> index 8a18348..be8e91d 100644
> --- a/drivers/usb/gadget/legacy/gmidi.c
> +++ b/drivers/usb/gadget/legacy/gmidi.c
> @@ -21,19 +21,12 @@
>  /* #define VERBOSE_DEBUG */
>  
>  #include <linux/kernel.h>
> -#include <linux/slab.h>
>  #include <linux/module.h>
> -#include <linux/device.h>
>  
> -#include <sound/core.h>
>  #include <sound/initval.h>
> -#include <sound/rawmidi.h>
>  
> -#include <linux/usb/ch9.h>
>  #include <linux/usb/composite.h>
>  #include <linux/usb/gadget.h>
> -#include <linux/usb/audio.h>
> -#include <linux/usb/midi.h>
>  
>  #include "u_midi.h"
>  
> @@ -42,7 +35,6 @@
>  MODULE_AUTHOR("Ben Williamson");
>  MODULE_LICENSE("GPL v2");
>  
> -static const char shortname[] = "g_midi";
>  static const char longname[] = "MIDI Gadget";
>  
>  USB_GADGET_COMPOSITE_OPTIONS();
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ