linux-kernel - Re: [PATCH 3.19.y-ckt 046/155] ASoC: sgtl5000: fix wrong register MIC_BIAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5645A83E.9060606@eurek.it>
Date:	Fri, 13 Nov 2015 10:07:10 +0100
From:	gianluca <gianlucarenzi@...ek.it>
To:	Kamal Mostafa <kamal@...onical.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, kernel-team@...ts.ubuntu.com
Cc:	Gianluca Renzi <gianlucarenzi@...ekelettronica.it>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 3.19.y-ckt 046/155] ASoC: sgtl5000: fix wrong register
 MIC_BIAS_VOLTAGE setup on probe

On 11/13/2015 12:16 AM, Kamal Mostafa wrote:
> 3.19.8-ckt10 -stable review patch.  If anyone has any objections, please let me know.
>

yes, it should works. Please add the correct message in the device-tree 
probe for the micbias voltage too. Just to have the same behaviour.


> ------------------
>
> From: Gianluca Renzi <gianlucarenzi@...ekelettronica.it>
>
> commit e256da84a04ea31c3c215997c847609af224e8f4 upstream.
>
> Signed-off-by: Gianluca Renzi <gianlucarenzi@...ekelettronica.it>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> ---
>   sound/soc/codecs/sgtl5000.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 10d2415..d91790e 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -1337,8 +1337,8 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
>   			sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
>
>   	snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
> -			SGTL5000_BIAS_R_MASK,
> -			sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
> +			SGTL5000_BIAS_VOLT_MASK,
> +			sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
>   	/*
>   	 * disable DAP
>   	 * TODO:
>


-- 
Eurek s.r.l.                          |
Electronic Engineering                | http://www.eurek.it
via Celletta 8/B, 40026 Imola, Italy  | Phone: +39-(0)542-609120
p.iva 00690621206 - c.f. 04020030377  | Fax:   +39-(0)542-609212
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/