| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Nov 2015 10:16:51 +0100 From: Michal Hocko <mhocko@...nel.org> To: David Rientjes <rientjes@...gle.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] mm: get rid of __alloc_pages_high_priority On Thu 12-11-15 12:47:45, David Rientjes wrote: > On Thu, 12 Nov 2015, mhocko@...nel.org wrote: [...] > > Hi, > > I think that this is more a cleanup than any functional change. We > > are rarely screwed so much that __alloc_pages_high_priority would > > fail. Yet I think that __alloc_pages_high_priority is obscuring the > > overal intention more than it is helpful. Another motivation is to > > reduce wait_iff_congested call to a single one in the allocator. I plan > > to do other changes in that area and get rid of it altogether. > > I think it's a combination of a cleanup (the inlining of > __alloc_pages_high_priority) and a functional change (no longer looping > infinitely around a get_page_from_freelist() call). I'd suggest doing the > inlining in one patch and then the reworking of __GFP_NOFAIL when > ALLOC_NO_WATERMARKS fails just so we could easily revert the latter if > necessary. I can split it up if this is really preferable of course. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists