linux-kernel - Re: [PATCH] net: phy: vitesse: add support for VSC8601

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xk2pmkyck.fsf@unicorn.mansr.com>
Date:	Fri, 13 Nov 2015 10:06:19 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Mason <slash.tmp@...e.fr>
Cc:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: vitesse: add support for VSC8601

Mason <slash.tmp@...e.fr> writes:

> On 12/11/2015 19:41, Mans Rullgard wrote:
>
>> +	.phy_id         = PHY_ID_VSC8601,
>> +	.name           = "Vitesse VSC8601",
>> +	.phy_id_mask    = 0x000ffff0,
>> +	.features       = PHY_GBIT_FEATURES,
>> +	.flags          = PHY_HAS_INTERRUPT,
>> +	.config_init    = &genphy_config_init,
>> +	.config_aneg    = &genphy_config_aneg,
>> +	.read_status    = &genphy_read_status,
>> +	.ack_interrupt  = &vsc824x_ack_interrupt,
>> +	.config_intr    = &vsc82xx_config_intr,
>
> I expected Documentation/CodingStyle to forbid taking the address
> of functions.

I can't find anything to that effect.  That said, it's not something I
would normally do, but all the other phy_driver entries in that file
look like that.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/