linux-kernel - Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5645E6AE.4040402@sigmadesigns.com>
Date:	Fri, 13 Nov 2015 14:33:34 +0100
From:	Marc Gonzalez <marc_gonzalez@...madesigns.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by
 clocksource_mmio_init

On 13/11/2015 11:58, Daniel Lezcano wrote:

> The current code to initialize, register and read the clocksource is
> already factored out in mmio.c via the clocksource_mmio_init function.
> 
> Factor out the code with the clocksource_mmio_init function.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/clocksource/tango_xtal.c | 18 +++---------------
>  1 file changed, 3 insertions(+), 15 deletions(-)

Hello Daniel,

I think you also need:

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 63c878d4d9e3..92bf3fc3e646 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -278,6 +278,7 @@ config CLKSRC_MIPS_GIC
 config CLKSRC_TANGO_XTAL
        bool
        select CLKSRC_OF
+       select CLKSRC_MMIO
 
 config CLKSRC_PXA
        def_bool y if ARCH_PXA || ARCH_SA1100


Otherwise, we'll get "undefined reference" link errors.

Regards.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/