linux-kernel - Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5645F35B.7090503@linaro.org>
Date:	Fri, 13 Nov 2015 15:27:39 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	"moderated list:ARM/Allwinner A1X..." 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by
 clocksource_mmio_init

On 11/13/2015 12:31 AM, Maxime Ripard wrote:
> On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> The only difference is the readl vs readl_relaxed.
>>
>> Factor out the code with the clocksource_mmio_init function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Thanks for the review. I applied the patch with a fix:

ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
			node->name,
			rate, 340, UINT_MAX,
			clocksource_mmio_readl_down);

Replaced UINT_MAX by '32'.

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/