linux-kernel - Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56460D4F.5010807@baylibre.com>
Date:	Fri, 13 Nov 2015 17:18:23 +0100
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Paul Walmsley <paul@...an.com>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Brian Hutchinson <b.hutchman@...il.com>,
	Frode Isaksen <fisaksen@...libre.com>
Subject: Re: [PATCH 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx
 hwmod data

On 11/13/2015 03:41 PM, Tony Lindgren wrote:
> * Neil Armstrong <narmstrong@...libre.com> [151112 06:16]:
>> On 10/24/2015 12:09 PM, Neil Armstrong wrote:
>>> Hi,
>>>
>>> 2015-10-24 3:21 GMT+02:00 Tony Lindgren <tony@...mide.com>:
>>>>
>>>> Hi,
>>>>
>>>> * Neil Armstrong <narmstrong@...libre.com> [151022 02:19]:
>>>>> Add missing HWMOD_NO_IDLEST hwmod flag for entries no
>>>>> having omap4 clkctrl values.
>>>>
>>>> Have you checked this is the case both in dm814x and dm816x TRM?
>>>> Also the documentation may not be complete FYI, might be also
>>>> worth checking the legacy TI kernel tree to be sure.
>>>>
>>>> Regards,
>>>>
>>>> Tony
>>>>
>>>>> Cc: Brian Hutchinson <b.hutchman@...il.com>
>>>>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>>>>> ---
>>>>>  arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>>>>> index b1288f5..6256052 100644
>>>>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>>>>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>>>>> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = {
>>>>>       .name           = "l4_ls",
>>>>>       .clkdm_name     = "alwon_l3s_clkdm",
>>>>>       .class          = &l4_hwmod_class,
>>>>> +     .flags          = HWMOD_NO_IDLEST,
>>>>>  };
>>> In DM814x TRM, the CM_ALWON_L3_SLOW_CLKSTCTRL does not have IDLEST field.
>>> Same in DM816x TRM.
>>>
>>>>>
>>>>>  /*
>>>>> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = {
>>>>>       .name           = "l4_hs",
>>>>>       .clkdm_name     = "alwon_l3_med_clkdm",
>>>>>       .class          = &l4_hwmod_class,
>>>>> +     .flags          = HWMOD_NO_IDLEST,
>>>>>  };
>>> In DM814x TRM, the CM_ALWON_L3_MED_CLKSTCTRL does not have IDLEST field.
>>> Same in DM816x TRM.
>>>
>>>>>
>>>>>  /* L3 slow -> L4 ls peripheral interface running at 125MHz */
>>>>> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = {
>>>>>       .name           = "emac0",
>>>>>       .clkdm_name     = "alwon_ethernet_clkdm",
>>>>>       .class          = &dm816x_emac_hwmod_class,
>>>>> +     .flags          = HWMOD_NO_IDLEST,
>>>>>  };
>>> In this particular case, the IDLEST is handled in the MDIO hwmod.
>>>
>>>>>
>>>>>  static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = {
>>>>> --
>>>>> 1.9.1
>>>
>>> I'll check the TI tree to be sure...
>>>
>>> Regards,
>>> Neil
>>>
>> Tony,
>>
>> In TI's tree, there is no L3_MED hwmod but the L3_SLOW hwmod has NO_IDLEST flag.
>>
>> Is there any other issue about this patchset ?
> 
> Thanks for checking. Well one thing, if this is needed as fix, then a
> description of what happens without it would be good to have.
> 
> Regards,
> 
> Tony
> 
Tony,

I'll send a patchset with the error lines in a few minutes.

Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/