linux-kernel - Re: [PATCH] serial: 8250_mid: Add missing dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VescZjQWaP8ROmLEzxhKc=k0udFpfjWXm7qxxm_NxL9-w@mail.gmail.com>
Date:	Fri, 13 Nov 2015 03:31:04 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_mid: Add missing dependency

On Thu, Nov 12, 2015 at 3:21 PM, Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
> 8250_mid uses rational_best_approximation() function, so the
> driver needs to select CONFIG_RATIONAL option.
>
> This fixes build error when CONFIG_RATIONAL is not enabled:
>
> drivers/built-in.o: In function `mid8250_set_termios':
> 8250_mid.c:(.text+0x10169a): undefined reference to `rational_best_approximation'
>

Oh, man, I have the same fix in my local tree for weeks ;-)

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>  drivers/tty/serial/8250/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index e6f5e12..6412f14 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -373,6 +373,7 @@ config SERIAL_8250_MID
>         depends on SERIAL_8250 && PCI
>         select HSU_DMA if SERIAL_8250_DMA
>         select HSU_DMA_PCI if X86_INTEL_MID
> +       select RATIONAL
>         help
>           Selecting this option will enable handling of the extra features
>           present on the UART found on Intel Medfield SOC and various other
> --
> 2.6.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/