linux-kernel - Re: [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49si494nuf.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 13 Nov 2015 15:59:52 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Jens Axboe <axboe@...com>, Alexander Graf <agraf@...e.com>,
	Christoph Hellwig <hch@....de>,
	Ming Lei <tom.leiming@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity

Hannes Reinecke <hare@...e.de> writes:

> Signed-off-by: Hannes Reinecke <hare@...e.de>
> Reviewed-by: Christoph Hellwig <hch@....de>

Introduced by the code refactoring in 7b0576a3d835b4d46ed85d817ce016e90bf293a3.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

> ---
>  drivers/block/loop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index e790487..7272055 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1310,7 +1310,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) {
>  	return err;
>  }
>  
> -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)
> +static int loop_set_capacity(struct loop_device *lo)
>  {
>  	if (unlikely(lo->lo_state != Lo_bound))
>  		return -ENXIO;
> @@ -1373,7 +1373,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
>  	case LOOP_SET_CAPACITY:
>  		err = -EPERM;
>  		if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN))
> -			err = loop_set_capacity(lo, bdev);
> +			err = loop_set_capacity(lo);
>  		break;
>  	case LOOP_SET_DIRECT_IO:
>  		err = -EPERM;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/