lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Nov 2015 12:38:15 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Anjali Menon <cse.anjalimenon@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote: > Used double equal sign instead of equal to sign in the if condition > to remove the error detected by checkpatch.pl. > > ERROR: do not use assignment in if condition > > Signed-off-by: Anjali Menon <cse.anjalimenon@...il.com> > --- > drivers/staging/staging/drivers/staging/most/aim-cdev/cdev.c | 2 +- something wrong with your tree. This path doesnot exist. But in any case, i think the patch is wrong. wait_event_interruptible() is executed when most_get_mbo() returns NULL. so if you do mbo == most_get_mbo() it will immediately come out of sleep as the condition is true. I think here the intention was to sleep as long as most_get_mbo() returns NULL. And when it returns a valid pointer it is saved in mbo variable so that it can be used later in copy_from_user(). regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists