linux-kernel - Re: [PATCH] iio: adc: ad7793: removed unnecessary else.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56486922.4030705@kernel.org>
Date:	Sun, 15 Nov 2015 11:14:42 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Nizam Haider <nizamhaider786@...il.com>
Cc:	lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
	pmeerw@...erw.net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nizam Haider <nijamh@...c.in>
Subject: Re: [PATCH] iio: adc: ad7793: removed unnecessary else.

On 09/11/15 12:50, Nizam Haider wrote:
> Else is not generally useful after a break or return.
> 
> Signed-off-by: Nizam Haider <nijamh@...c.in>
Applied, thanks.

Jonathan
> ---
>  drivers/iio/adc/ad7793.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index eea0c79..3bc5655 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
>  				*val2 = st->
>  					scale_avail[(st->conf >> 8) & 0x7][1];
>  				return IIO_VAL_INT_PLUS_NANO;
> -			} else {
> -				/* 1170mV / 2^23 * 6 */
> -				scale_uv = (1170ULL * 1000000000ULL * 6ULL);
>  			}
> +			/* 1170mV / 2^23 * 6 */
> +			scale_uv = (1170ULL * 1000000000ULL * 6ULL);
>  			break;
>  		case IIO_TEMP:
>  				/* 1170mV / 0.81 mV/C / 2^23 */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/