linux-kernel - Re: [PATCH] drivers:pci:hotplug Fix simple_strtoul is obsolete, use kstrtoul instead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151115161148.GA12585@roeck-us.net>
Date:	Sun, 15 Nov 2015 08:11:48 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Bogicevic Sasa <brutallesale@...il.com>
Cc:	bhelgaas@...gle.com, wangyijing@...wei.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:pci:hotplug Fix  simple_strtoul is obsolete, use
 kstrtoul instead

On Sun, Nov 15, 2015 at 01:43:55PM +0100, Bogicevic Sasa wrote:
> This fixes messages "simple_strtoul is obsolete, use kstrtoul instead"
> from checkpatch.pl script
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@...il.com>
> ---
>  drivers/pci/hotplug/pci_hotplug_core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index d379d49..a1160c8 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -103,7 +103,7 @@ static ssize_t power_write_file(struct pci_slot *pci_slot, const char *buf,
>  	u8 power;
>  	int retval = 0;
>  
> -	lpower = simple_strtoul(buf, NULL, 10);
> +	lpower = kstrtoul(buf, NULL, 10);

I take it you did not test this code, since it would probably result
in a crash. Does it even compile ?

Hint: When replacing one function call with another, it helps updating
the parameters.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/