linux-kernel - Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151115.125905.63907005203700143.davem@davemloft.net>
Date:	Sun, 15 Nov 2015 12:59:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andy.shevchenko@...il.com
Cc:	linux@...nbow-software.org, netdev@...r.kernel.org,
	romieu@...zoreil.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

From: Andy Shevchenko <andy.shevchenko@...il.com>
Date: Sun, 15 Nov 2015 04:30:25 +0200

> On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary
>> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev)
>>
>>         alloc_list (dev);
>>
>> -       /* Get station address */
>> -       for (i = 0; i < 6; i++)
>> -               dw8(StationAddr0 + i, dev->dev_addr[i]);
>> +       /* Set station address */
>> +       for (i = 0; i < 3; i++)
>> +               dw16(StationAddr0 + 2 * i,
>> +                    cpu_to_le16(((u16 *)dev->dev_addr)[i]));
> 
> Is it specific requirement for new HW? If not, may be another patch
> with micro optimizations.

I absolutely agree, this definitely should not just be blindly copied
over from the other driver.

And if it is a requirement:

1) It must be documented as per why, both in a comment above the loop
   and in the commit log message.

2) It must therefore be tested on dl2k chips that worked with the
   dl2k driver beforehand to prove that it doesn't break them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/