lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Nov 2015 01:45:45 +0000 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Dāvis Mosāns" <davispuh@...il.com>, "Johannes Thumshirn" <jthumshirn@...e.de>, "Tomas Henzl" <thenzl@...hat.com>, "James Bottomley" <JBottomley@...n.com> Subject: [PATCH 3.2 49/60] mvsas: Fix NULL pointer dereference in mvs_slot_task_free 3.2.73-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Dāvis Mosāns <davispuh@...il.com> commit 2280521719e81919283b82902ac24058f87dfc1b upstream. When pci_pool_alloc fails in mvs_task_prep then task->lldd_task stays NULL but it's later used in mvs_abort_task as slot which is passed to mvs_slot_task_free causing NULL pointer dereference. Just return from mvs_slot_task_free when passed with NULL slot. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=101891 Signed-off-by: Dāvis Mosāns <davispuh@...il.com> Reviewed-by: Tomas Henzl <thenzl@...hat.com> Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de> Signed-off-by: James Bottomley <JBottomley@...n.com> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/scsi/mvsas/mv_sas.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -991,6 +991,8 @@ static void mvs_slot_free(struct mvs_inf static void mvs_slot_task_free(struct mvs_info *mvi, struct sas_task *task, struct mvs_slot_info *slot, u32 slot_idx) { + if (!slot) + return; if (!slot->task) return; if (!sas_protocol_ata(task->task_proto)) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists