lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Nov 2015 09:15:27 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: yjin <yanjiang.jin@...driver.com> cc: Steven Rostedt <rostedt@...dmis.org>, mingo@...hat.com, bigeasy@...utronix.de, peterz@...radead.org, linux-kernel@...r.kernel.org, jinyanjiang@...il.com, stable-rt@...r.kernel.org, linux-rt-users@...r.kernel.org Subject: Re: [RT PATCH] sched: rt: fix two possible deadlocks in push_irq_work_func On Sat, 14 Nov 2015, yjin wrote: > On 2015年11月14日 12:25, Steven Rostedt wrote: > > On Sat, 14 Nov 2015 10:53:18 +0800 > > <yanjiang.jin@...driver.com> wrote: > > > > > From: Yanjiang Jin <yanjiang.jin@...driver.com> > > > > > > This can only happen in RT kernel due to run_timer_softirq() calls > > > irq_work_tick() when CONFIG_PREEMPT_RT_FULL is enabled as below: > > > > > > static void run_timer_softirq(struct softirq_action *h) > > > { > > > ........ > > > if defined(CONFIG_IRQ_WORK) && defined(CONFIG_PREEMPT_RT_FULL) > > > irq_work_tick(); > > > endif > > > ........ > > > } > > > > > > Use raw_spin_{un,}lock_irq{save,restore} in push_irq_work_func() to > > > prevent following potentially deadlock scenario: > > Ug. No, the real fix is that the irq work is to be run from hard > > interrupt context. > But if so, we shouldn't call irq_work_tick() in run_timer_softirq(), right? The work is marked IRQ_WORK_HARD_IRQ so it should be run from hard irq context. We only run the work, which is not marked IRQ_WORK_HARD_IRQ from the softirq on RT. Thanks, tglx
Powered by blists - more mailing lists