linux-kernel - Re: [PATCH] lightnvm: change max_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACnwZYejgm-n80FH8yxtZn15_HDgMjL4tB89os+MO4oVzgL2GA@mail.gmail.com>
Date:	Mon, 16 Nov 2015 09:18:04 -0200
From:	Thiago Farina <tfransosi@...il.com>
To:	Matias Bjørling <m@...rling.me>
Cc:	linux-block@...r.kernel.org,
	linux list <linux-kernel@...r.kernel.org>, axboe@...com,
	geert@...ux-m68k.org
Subject: Re: [PATCH] lightnvm: change max_phys_sect to ushort

On Thu, Nov 12, 2015 at 4:35 PM, Matias Bjørling <m@...rling.me> wrote:
> The max_phys_sect variable is defined as a char. We do a boundary check
> to maximally allow 256 physical page descriptors per command. As we are
> not indexing from zero. This expression is always in false. Bump the
> max_phys_sect to an unsigned short to support the range check.
>
You might have to change the commit message to match the code change.
s/unsigned short/unsigned int. RIght?

> Signed-off-by: Matias Bjørling <m@...rling.me>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  include/linux/lightnvm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> index 69c9057..4b1cd3d 100644
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -220,7 +220,7 @@ struct nvm_dev_ops {
>         nvm_dev_dma_alloc_fn    *dev_dma_alloc;
>         nvm_dev_dma_free_fn     *dev_dma_free;
>
> -       uint8_t                 max_phys_sect;
> +       unsigned int max_phys_sect;
>  };
>
>  struct nvm_lun {


-- 
Thiago Farina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/