linux-kernel - Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5649C0DC.6080709@felipetonello.com>
Date:	Mon, 16 Nov 2015 11:41:16 +0000
From:	Felipe Ferreri Tonello <eu@...ipetonello.com>
To:	Clemens Ladisch <clemens@...isch.de>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	linux-usb@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Robert Baldyga <r.baldyga@...sung.com>
Subject: Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for
 MIDIStreaming interface

Hi Clemens,

On 13/11/15 08:11, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 10/11/15 18:43, Sergei Shtylyov wrote:
>>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>>       struct usb_ep        *in_ep, *out_ep;
>>>>       struct snd_card        *card;
>>>>       struct snd_rawmidi    *rmidi;
>>>> +    u8                    ms_id;
>>>
>>>   Why 'ms_id' is not aligned with the above field names?
>>
>> It is actually aligned.
> 
> It's not in the original mail, which contains tab characters.
> 
>> Here is from my local git diff:
>>
>> @@ -75,6 +75,7 @@ struct f_midi {
>>     struct usb_ep       *in_ep, *out_ep;
>>     struct snd_card     *card;
>>     struct snd_rawmidi  *rmidi;
>> +   u8                  ms_id;
> 
> Apparently, you're using four spaces per tab.  Linux uses eight.

Yes. I'll fix that.

-- 
Felipe

Download attachment "0x92698E6A.asc" of type "application/pgp-keys" (4831 bytes)