lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Nov 2015 12:34:43 +0900 From: Takuya Yoshikawa <yoshikawa_takuya_b1@....ntt.co.jp> To: Marcelo Tosatti <mtosatti@...hat.com> Cc: pbonzini@...hat.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 06/10] KVM: x86: MMU: Consolidate WARN_ON/BUG_ON checks for reverse-mapped sptes On 2015/11/14 7:08, Marcelo Tosatti wrote: > On Thu, Nov 12, 2015 at 08:53:43PM +0900, Takuya Yoshikawa wrote: >> At some call sites of rmap_get_first() and rmap_get_next(), BUG_ON is >> placed right after the call to detect unrelated sptes which must not be >> found in the reverse-mapping list. >> >> Move this check in rmap_get_first/next() so that all call sites, not >> just the users of the for_each_rmap_spte() macro, will be checked the >> same way. In addition, change the BUG_ON to WARN_ON since killing the >> whole host is the last thing that KVM should try. > > It should be a BUG_ON, if KVM continues it will corrupt (more) memory. In the sense that we cannot predict what kind of corruption it will cause, I agree with you. But if it can only corrupt that guest's memory, it is a bit sad to kill unrelated guests, and host, too. Anyway, since we cannot say for sure what a possible bug can cause, I agree with you now. Thanks, Takuya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists