linux-kernel - Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151116112508.6e6f3a5d@gandalf.local.home>
Date:	Mon, 16 Nov 2015 11:25:08 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace/x86: Fix missing ops arg on static function
 tracing

On Mon, 16 Nov 2015 10:54:53 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> This isn't needed, nor will the parameter be used if added. A comment
> should probably be added here instead.
> 
> /*
>  * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
>  * set (see include/asm/ftrace.h). Only the ip and parent ip are used

Probably should also add "and include/linux/ftrace.h" as that's where
the ARCH_SUPPORTS_FTRACE_OPS is described.

-- Steve

>  * and the list function is called when function tracing is enabled.
>  */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/