linux-kernel - Re: [PATCH] usb: phy: msm: fix a possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lh9xna93.fsf@saruman.tx.rr.com>
Date:	Mon, 16 Nov 2015 11:07:36 -0600
From:	Felipe Balbi <balbi@...com>
To:	LABBE Corentin <clabbe.montjoie@...il.com>,
	<gregkh@...uxfoundation.org>
CC:	LABBE Corentin <clabbe.montjoie@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: phy: msm: fix a possible NULL dereference


Hi,

LABBE Corentin <clabbe.montjoie@...il.com> writes:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later. Renaming id to of_id (like all others do) in the
> process.
>
> Reported-by: coverity (CID 1324133)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> ---
>  drivers/usb/phy/phy-msm-usb.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 80eb991..c4a66cf 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1506,20 +1506,23 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
>  {
>  	struct msm_otg_platform_data *pdata;
>  	struct extcon_dev *ext_id, *ext_vbus;
> -	const struct of_device_id *id;
> +	const struct of_device_id *of_id;

and why did you need to rename this variable ? Please resend without the
variable rename.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)