linux-kernel - Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874mglx2p7.fsf@vitty.brq.redhat.com>
Date:	Mon, 16 Nov 2015 18:40:36 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...uxdriverproject.org,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Olaf Hering <olaf@...fle.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

Dan Carpenter <dan.carpenter@...cle.com> writes:

> On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
>> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf,
>>  		return PTR_ERR(inmsg);
>>  
>>  	if (hvt->on_msg(inmsg, count))
>> -		return -EFAULT;
>> +		ret = -EFAULT;
>
> You fix this leak and then re-introduce it again directly in patch
> 3/4.

Such a shame ... Thanks for noticing!

> Also it might be nice to preserve the error code.
>
> 	ret = hvt->on_msg(inmsg, count);
>
> 	kfree(inmsg);
>
> 	return ret ? ret : count;

It seems on_msg() hooks can only return -EINVAL now but why not
... let's do it in v2.

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/