linux-kernel - Re: [PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wc5OoSctt8rGhW+y2e0sMBP+6zQJPZ5A0OO5k3+G_FWA@mail.gmail.com>
Date:	Mon, 16 Nov 2015 10:27:04 -0800
From:	Doug Anderson <dianders@...omium.org>
To:	Yunzhi Li <lyz@...k-chips.com>
Cc:	John Youn <John.Youn@...opsys.com>,
	Julius Werner <jwerner@...gle.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	wulf <wulf@...k-chips.com>,
	Kever Yang <kever.yang@...k-chips.com>,
	frank.wang@...k-chips.com, Tao Huang <huangtao@...k-chips.com>,
	caesar <caesar.wang@...k-chips.com>
Subject: Re: [PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

Yunzhi

On Mon, Nov 16, 2015 at 7:25 AM, Yunzhi Li <lyz@...k-chips.com> wrote:
> When checking dwc2 host channel interrupts, handle qh in
> periodic_sched_queued list at first, then we could make sure CSPLIT
> packets scheduled in the same order as SSPLIT packets.
>
> Signed-off-by: Yunzhi Li <lyz@...k-chips.com>
> ---
>  drivers/usb/dwc2/hcd_intr.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

This seems like a very reasonable fix to me.  I also bought the same
keyboard you were debugging with (The Das Keyboard 4 Ultimate Clicky)
and confirmed that problems are fixed by this patch on the
rk3288-based veyron-jerry sitting on my desk.


Reviewed-by: Douglas Anderson <dianders@...omium.org>
Tested-by: Douglas Anderson <dianders@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/