linux-kernel - Re: [PATCH] net: dsa: Delete an unnecessary check before the function call "put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151116.151156.22243959928293016.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 15:11:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	elfring@...rs.sourceforge.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH] net: dsa: Delete an unnecessary check before the
 function call "put_device"

I'm starting to grow quite weary of these "unnecessary check" changes.

Sometimes it is better to have them, either because the path is a hot
path or some atomic sequence is involved.

But there is never harm in them being there.

All of this is a matter of taste, of course.  But one thing I know for
sure, it is undisputable that there are much more important things to
work on than this kind of stuff...

So I'm not applying these changes any more and directing my time and
effort to reviewing and applying patches that fix bugs, really
restructure the code in useful ways that increase maintainability over
the long time, and add interesting new features.

These patches do none of the above.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/