linux-kernel - Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151116.155327.1432148371996261050.davem@davemloft.net>
Date:	Mon, 16 Nov 2015 15:53:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mans@...sr.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800
 Ethernet controller

From: Mans Rullgard <mans@...sr.com>
Date: Mon, 16 Nov 2015 18:23:35 +0000

> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)

"i" is passed in as a signed int here, but:

> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
 ...
> +		err = nb8800_alloc_rx(dev, i, true);

It comes from an 'unsigned' value.

Please pick one type and use it consistently.

Also, always fully spell out "unsigned int" rather than use "unsigned"
as a shorthand.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/