lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2015 10:17:40 +1000 From: Greg Ungerer <gerg@...inux.org> To: Geert Uytterhoeven <geert@...ux-m68k.org>, Sam Creasey <sammy@...my.net>, linux-m68k@...ts.linux-m68k.org Cc: linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and {min,max}_low_pfn Hi Geert, On 15/11/15 21:04, Geert Uytterhoeven wrote: > This patch series adds missing initialization of max_pfn, min_low_pfn, > and max_low_pfn on various m68k platforms. > > This was exposed by failing selftests/vm/mlock2-tests. > > Note that several other architectures lack a proper initialization of > max_pfn. On some of them it's completely missing, on others max_pfn is a > local variable, hence it hides the global max_pfn, which is thus not > initialized neither. > > On platforms with MMU, this can easily be verified by reading the > following virtual files (CONFIG_PROC_PAGE_MONITOR=y): > > /proc/kpagecount > /proc/kpageflags > /proc/kpagecgroup (CONFIG_MEMCG=y) > > If max_pfn is not initialized, all three virtual files are empty. > > Besides the above, max_pfn is also used to calculate DMA masks for block > devices. An uninitialized (zero) value means all RAM is suitable for > DMA. All looks good to me. Tested-by acks set separately. But otherwise Acked-by: Greg Ungerer <gerg@...inux.org> Regards Greg > Absence of initialization of min_low_pfn and max_low_pfn is more subtle. > (are there any bad side-effects?). > > Geert Uytterhoeven (4): > m68k/mm: motorola - Add missing initialization of max_pfn > m68k/mm: m54xx - Add missing initialization of max_pfn > m68k/mm: sun3 - Add missing initialization of max_pfn and > {min,max}_low_pfn > m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn > > arch/m68k/coldfire/m54xx.c | 2 +- > arch/m68k/kernel/setup_no.c | 9 ++++++--- > arch/m68k/mm/motorola.c | 2 +- > arch/m68k/sun3/config.c | 4 ++-- > 4 files changed, 10 insertions(+), 7 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists