linux-kernel - Re: [PATCH 1/2] Remove EFI memmap quirk for UV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151117095208.GC2727@codeblueprint.co.uk>
Date:	Tue, 17 Nov 2015 09:52:08 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Alex Thorlton <athorlton@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Hedi Berriche <hedi@....com>,
	Dimitri Sivanich <sivanich@....com>, x86@...nel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH 1/2] Remove EFI memmap quirk for UV

On Mon, 16 Nov, at 07:02:48PM, Thomas Gleixner wrote:
> On Mon, 16 Nov 2015, Alex Thorlton wrote:
> 
> CC'ing Matt under his correct e-mail address.
> 
> > Commit a5d90c923bcf ("x86/efi: Quirk out SGI UV") added a quirk to
> > efi_apply_memmap_quirks to force SGI UV systems to fall back to the old
> > EFI memmap mechanism.  We have a BIOS fix for this issue now, so we no
> > longer need this quirk in the kernel.  This commit removes the quirk
> > from the function in question.
> > 
> > Signed-off-by: Alex Thorlton <athorlton@....com>
> > Acked-by: Mike Travis <travis@....com>
> > Acked-by: Russ Anderson <rja@....com>
> > Cc: Matt Fleming <matt.fleming@...el.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: "H. Peter Anvin" <hpa@...or.com>
> > Cc: Hedi Berriche <hedi@....com>
> > Cc: Dimitri Sivanich <sivanich@....com>
> > Cc: x86@...nel.org
> > Cc: linux-efi@...r.kernel.org
> > 
> > ---
> >  arch/x86/platform/efi/quirks.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
> > index 1c7380d..96b417c 100644
> > --- a/arch/x86/platform/efi/quirks.c
> > +++ b/arch/x86/platform/efi/quirks.c
> > @@ -259,12 +259,6 @@ void __init efi_apply_memmap_quirks(void)
> >  		pr_info("efi: Setup done, disabling due to 32/64-bit mismatch\n");
> >  		efi_unmap_memmap();
> >  	}
> > -
> > -	/*
> > -	 * UV doesn't support the new EFI pagetable mapping yet.
> > -	 */
> > -	if (is_uv_system())
> > -		set_bit(EFI_OLD_MEMMAP, &efi.flags);

Awesome! Thanks Alex.

Can I also close https://bugzilla.kernel.org/show_bug.cgi?id=75021 ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/