linux-kernel - Re: [PATCH v2 08/19] ARC: Mark secondary cpu online only after all HW setup is done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564B0CBB.8060206@synopsys.com>
Date:	Tue, 17 Nov 2015 16:47:15 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Noam Camus <noamc@...hip.com>, <linux-snps-arc@...ts.infradead.org>
CC:	<linux-kernel@...r.kernel.org>, <talz@...hip.com>,
	<gilf@...hip.com>, <cmetcalf@...hip.com>
Subject: Re: [PATCH v2 08/19] ARC: Mark secondary cpu online only after all HW
 setup is done

On Saturday 07 November 2015 04:22 PM, Noam Camus wrote:
> From: Noam Camus <noamc@...hip.com>
> 
> In SMP setup, master loops for each_present_cpu calling cpu_up().
> For ARC it returns as soon as new cpu's status becomes online,
> However secondary may still do HW initializing,
> machine or platform hook level.
> 
> So turn secondary online only after all HW setup is done.
> Signed-off-by: Noam Camus <noamc@...hip.com>

Acked-by: Vineet Gupta <vgupta@...opsys.com>

> ---
>  arch/arc/kernel/smp.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
> index 0b061a4..bc0e4f6 100644
> --- a/arch/arc/kernel/smp.c
> +++ b/arch/arc/kernel/smp.c
> @@ -126,11 +126,6 @@ void start_kernel_secondary(void)
>  	current->active_mm = mm;
>  	cpumask_set_cpu(cpu, mm_cpumask(mm));
>  
> -	notify_cpu_starting(cpu);
> -	set_cpu_online(cpu, true);
> -
> -	pr_info("## CPU%u LIVE ##: Executing Code...\n", cpu);
> -
>  	/* Some SMP H/w setup - for each cpu */
>  	if (plat_smp_ops.init_per_cpu)
>  		plat_smp_ops.init_per_cpu(cpu);
> @@ -138,6 +133,11 @@ void start_kernel_secondary(void)
>  	if (machine_desc->init_cpu_smp)
>  		machine_desc->init_cpu_smp(cpu);
>  
> +	notify_cpu_starting(cpu);
> +	set_cpu_online(cpu, true);
> +
> +	pr_info("## CPU%u LIVE ##: Executing Code...\n", cpu);
> +
>  	arc_local_timer_setup();
>  
>  	local_irq_enable();
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/