linux-kernel - Re: [PATCH] perf record: Support custom vmlinux path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2015 20:45:28 +0800
From:	pi3orama <pi3orama@....com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	He Kuang <hekuang@...wei.com>, Wang Nan <wangnan0@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Alexei Starovoitov <ast@...nel.org>, lizefan@...wei.com,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf record: Support custom vmlinux path



发自我的 iPhone

> 在 2015年11月17日，下午8:42，Arnaldo Carvalho de Melo <acme@...nel.org> 写道：
> 
> Em Tue, Nov 17, 2015 at 09:33:40AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu:
>> 
>> Thanks, applying.
> 
> I take that back, I think this is questionable, we should instead always
> have the --vmlinux option, and when the feature it deals with is not
> built in, warn the user about it, something like:
> 
>  #  perf record --vmlinux /a/b/c ...
>  WARNING: --vmlinux being ignored, as BPF prologue not built-in...
>  <output that can be produced while ignoring --vmlinux>
> 
> And please consider that for other options that are surrounded by ifdefs
> related to the eBPF support, there are a few more, clang related.
> 
> Also this isn't updating the perf-record man page, please do so and
> please put this in a separate section for BPF related options, something
> like:
> 
> --------------------
> 
> BPF:
> 
> These options can be used when BPF support is built-in.
> 
> ...
> 
> ---------------------
> 
> This way the user gets to know that the tool can be used with BPF while
> reading its documentation and if they decide to try it, then the
> warnings will be presented if the feature is not built-in.
> 

Ok. Thanks for your comment. I will do that tomorrow.

> - Arnaldo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/