linux-kernel - Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564B539B.9080003@osg.samsung.com>
Date:	Tue, 17 Nov 2015 17:19:39 +0100
From:	Stefan Schmidt <stefan@....samsung.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Alexander Aring <alex.aring@...il.com>,
	linux-wpan@...r.kernel.org,
	Network Development <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the
 function call "kfree_skb"

Hello.

On 17/11/15 15:01, Marcel Holtmann wrote:
> Hi Stefan,
>
>>> The kfree_skb() function tests whether its argument is NULL and then
>>> returns immediately. Thus the test around the call is not needed.
>>>
>>> This issue was detected by using the Coccinelle software.
>>>
>>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
>>> ---
>>>   drivers/net/ieee802154/atusb.c | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>>> index 199a94a..b1cd865 100644
>>> --- a/drivers/net/ieee802154/atusb.c
>>> +++ b/drivers/net/ieee802154/atusb.c
>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>>   		urb = usb_get_from_anchor(&atusb->idle_urbs);
>>>   		if (!urb)
>>>   			break;
>>> -		if (urb->context)
>>> -			kfree_skb(urb->context);
>>> +		kfree_skb(urb->context);
>>>   		usb_free_urb(urb);
>>>   	}
>>>   }
>> Acked-by: Stefan Schmidt <stefan@....samsung.com>
> for some reason I am missing the original patch, can someone resend it please.
>

Done. Resend the original message from my address but with the From line 
intact inside the patch. Please check if it really lists Markus as 
author when applying. Acked-by also resend as reply to the resend patch.

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/