lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2015 10:50:26 +0800 From: Daniel Kurtz <djkurtz@...omium.org> To: Hongzhou Yang <hongzhou.yang@...iatek.com> Cc: Linus Walleij <linus.walleij@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, Yingjoe Chen <yingjoe.chen@...iatek.com>, Axel Lin <axel.lin@...ics.com>, Maoguang Meng <maoguang.meng@...iatek.com>, Colin Ian King <colin.king@...onical.com>, linux-gpio@...r.kernel.org, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, linux-mediatek@...ts.infradead.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, srv_heupstream <srv_heupstream@...iatek.com>, Sascha Hauer <kernel@...gutronix.de>, biao.huang@...iatek.com Subject: Re: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps. On Tue, Nov 17, 2015 at 10:34 AM, Hongzhou Yang <hongzhou.yang@...iatek.com> wrote: > configs will kmemdup to dup_configs in pictrl util function. > So configs need to be freed. > > Signed-off-by: Hongzhou Yang <hongzhou.yang@...iatek.com> > --- > Fix a memleak issue. > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index bbf0230..0000b5a 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -568,9 +568,10 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, > } > } > > - return 0; > + err = 0; > > fail: This isn't just 'fail' case anymore, so change label name to something like "exit". > + kfree(configs); Do we also need to kfree in the "if (!num_pins || !maps_per_pin)" error case? > return err; > } > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists