linux-kernel - Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151118061927.GA6229@sudip-pc>
Date:	Wed, 18 Nov 2015 11:49:28 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Bogicevic Sasa <brutallesale@...il.com>
Cc:	gregkh@...uxfoundation.org, johnny.kim@...el.com,
	austin.shin@...el.com, chris.park@...el.com,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages

On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote:
> This fixes all "Comparison to NULL could be written like..."
> messages from checkpatch.pl
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@...il.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index fd7240c..a31ac55 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>  
>  		/* Get DTIM Period */
>  		pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index);
> -		if (pu8TimElm != NULL)
> +		if (!pu8TimElm)

You are now checking for -  if (pu8TimElm == NULL)	
It should actually be: if (pu8TimElm)

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/