linux-kernel - Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151118081205.GA9557@krava.brq.redhat.com>
Date:	Wed, 18 Nov 2015 09:12:05 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Wangnan (F)" <wangnan0@...wei.com>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Milian Wolff <milian.wolff@...b.com>
Subject: Re: [PATCH 2/3] perf tools: Add callchain order support for
 libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 08:54:31AM +0100, Jiri Olsa wrote:
> On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote:
> 
> SNIP
> 
> >      3.38%  a.out    a.out             [.] funcc
> >               |
> >               ---funcc
> >                  |
> >                  |--2.70%-- funcb
> >                  |          funca
> >                  |          main
> >                  |          __libc_start_main
> >                  |          _start
> >                  |
> >                   --0.68%-- 0
> > 
> > 
> > I'm not sure whether we can regard this behavior changing as a bugfix? I
> > think
> > there may be some reason the original code explicitly avoid creating an '0'
> > entry.
> > 
> > Then I tried to find why perf can't get call frame on my case, and
> > I guess there's something wrong whe dealing with 'call' command, because
> > the instruction on it I can't get callchain from libunwind is a 'callq':
> > 
> >   ...
> >   4005bf:       be 00 00 00 00          mov    $0x0,%esi
> >   4005c4:       48 89 c7                mov    %rax,%rdi
> >   4005c7:       e8 74 fe ff ff          callq  400440 <gettimeofday@plt>
> >                 us2 = tv2.tv_sec * 1000000 + tv2.tv_usec;
> >   4005cc:       48 8b 04 24             mov    (%rsp),%rax
> >   ...
> > 
> > But this is another problem, we can discuss it in a new thread.
> 
> so the problem is you dont see the gettimeofday call at the end?
> 
> could you share the test code?

just saw your other email on this issue.. let's continue there

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/