linux-kernel - Re: [PATCH] fault-inject: correct printk order for interval vs. probability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151118093945.4bbd6bd7@redhat.com>
Date:	Wed, 18 Nov 2015 09:39:45 +0100
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	akinobu.mita@...il.com, linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	dmonakhov@...nvz.org, brouer@...hat.com,
	Florian Westphal <fw@...len.de>
Subject: Re: [PATCH] fault-inject: correct printk order for interval vs.
 probability


Disregard this patch... Florian already fixed it in:

 bb387002693e ("fault-inject: fix inverted interval/probability values in printk")

$ git describe --contains bb387002693e
v4.3-rc7~11^2~1


On Tue, 17 Nov 2015 12:48:37 +0100
Jesper Dangaard Brouer <brouer@...hat.com> wrote:

> In function fail_dump() printk output of the attributes interval and
> probability got swapped.  This was introduced in commit
> 6adc4a22f20b ("fault-inject: add ratelimit option").
> 
> Fixes: 6adc4a22f20b ("fault-inject: add ratelimit option")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> 
> ---
> Don't know who is maintainer for lib/, hope someone will
> pick this up...
> 
>  lib/fault-inject.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index f1cdeb024d17..6a823a53e357 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
>  		printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
>  		       "name %pd, interval %lu, probability %lu, "
>  		       "space %d, times %d\n", attr->dname,
> -		       attr->probability, attr->interval,
> +		       attr->interval, attr->probability,
>  		       atomic_read(&attr->space),
>  		       atomic_read(&attr->times));
>  		if (attr->verbose > 1)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/