[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <564C402C.8030503@redhat.com>
Date: Wed, 18 Nov 2015 10:09:00 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
Takuya Yoshikawa <yoshikawa_takuya_b1@....ntt.co.jp>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] KVM: x86: MMU: Encapsulate the type of rmap-chain
head in a new struct
On 18/11/2015 04:21, Xiao Guangrong wrote:
>
>
> On 11/12/2015 07:55 PM, Takuya Yoshikawa wrote:
>> @@ -1720,7 +1724,7 @@ static struct kvm_mmu_page
>> *kvm_mmu_alloc_page(struct kvm_vcpu *vcpu,
>> * this feature. See the comments in kvm_zap_obsolete_pages().
>> */
>> list_add(&sp->link, &vcpu->kvm->arch.active_mmu_pages);
>> - sp->parent_ptes = 0;
>> + sp->parent_ptes.val = 0;
>
> The sp is allocated from kmem_cache_zalloc() so explicitly initialize it
> to zero is not needed.
Right, but it should be a separate patch.
Takuya, since you are going to send another version of this series, can
you also:
1) move this patch either to the beginning or to the end
2) include "KVM: x86: always set accessed bit in shadow PTEs", also near
the beginning of the series?
Thanks!
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists