lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Nov 2015 10:33:41 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org Cc: linux-samsung-soc@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>, Sangbeom Kim <sbkim73@...sung.com>, Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>, Kukjin Kim <kgene@...nel.org>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCHv2] ASoC: samsung: pass DMA channels as pointers On 18.11.2015 00:53, Arnd Bergmann wrote: > ARM64 allmodconfig produces a bunch of warnings when building the > samsung ASoC code: > > sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': > sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > playback_data->filter_data = (void *)playback->channel; > sound/soc/samsung/dmaengine.c:60:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > capture_data->filter_data = (void *)capture->channel; > > We could easily shut up the warning by adding an intermediate cast, > but there is a bigger underlying problem: The use of IORESOURCE_DMA > to pass data from platform code to device drivers is dubious to start > with, as what we really want is a pointer that can be passed into > a filter function. > > Note that on s3c64xx, the pl08x DMA data is already a pointer, but > gets cast to resource_size_t so we can pass it as a resource, and it > then gets converted back to a pointer. In contrast, the data we pass > for s3c24xx is an index into a device specific table, and we artificially > convert that into a pointer for the filter function. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > v2: > > - no longer clash with SPI patch > - don't reference platform data that might be NULL > Looks good: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists