linux-kernel - Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564CA9BC.8020903@canonical.com>
Date:	Wed, 18 Nov 2015 10:39:24 -0600
From:	Chris J Arges <chris.j.arges@...onical.com>
To:	Petr Mladek <pmladek@...e.com>
Cc:	live-patching@...r.kernel.org, jpoimboe@...hat.com,
	sjenning@...hat.com, jikos@...nel.org, vojtech@...e.com,
	jeyu@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to
 klp_reloc

On 11/18/2015 10:37 AM, Petr Mladek wrote:
> On Mon 2015-11-16 11:03:06, Chris J Arges wrote:
>> In cases of duplicate symbols, sympos will be used to disambiguate instead
>> of val. By default sympos will be 0, and patching will only succeed if
>> the symbol is unique. Specifying a positive value will ensure that
>> occurrence of the symbol in kallsyms for the patched object will be used
>> for patching if it is valid.
>>
>> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol
>> as they are no longer used.
>>
>> >From the klp_reloc structure remove val, as it can be refactored as a
>   ^
> Please, remove this extra '>'. I guess that you cut&pasted the
> comment from a mail reply ;-)
> 
> Best Regards,
> Petr
> 

I think that '>' was added in a subsequent reply. My patch doesn't have
that, and I'm guessing checkpatch would have warned me about that as well.
: )

--chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/